[Bug 24768] need CD API to list existing channels you might like to Observe

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24768





--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-03-25 07:06:29 PST ---
+        <p>If true, upon the startup of this observer, ObserveChannels will be
+        called for every already existing channel that this observer wants to
+        observe (ie. every channel that would cause ObserveChannels to be
called
+        on this observer upon creation).</p>

Insert a blank line between this paragraph and the next, please.

+        <p>If the observer is an activatable client, ObserveChannels won't be
+        emitted after the client is ready. Instead, it will be omitted
immediately
+        when the observer's well-known name disappears from the bus, so the
client
+        will be restarted immediately via DBus service activation.</p>

Methods are "called", not "emitted". They're certainly not "omitted", which is
something else entirely :-)

Also, I think this wording is a bit confusing. How about this?

         <p>If the Observer is service-activatable, instead of watching
           passively for a new instance of it to start, the channel
           dispatcher will call its ObserveChannels method as soon as
           its well-known name disappears, resulting in it being restarted
           immediately via D-Bus service activation.</p>

... and I'd like some rationale, like this:

         <tp:rationale>
           <p>This means that if an activatable Observer crashes, it will
             be restarted as soon as possible; while there is an unavoidable
             possibility that it will miss some events during this process
             (particularly <tp:dbus-ref 
               namespace="org.freedesktop.Channel.Type">Text</tp:dbus-ref>
             messages), this window of event loss is kept to a minimum.</p>

           <p>Non-activatable observers can't take advantage of this
             mechanism, but setting this property on a non-activatable
             observer does allow it to "catch up" on channels that are
             currently active at the time that it starts up.</p>
         </tp:rationale>


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.