[Bug 25493] GTalk-compatible file transfers are not implemented

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=25493





--- Comment #19 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-03-25 07:28:36 PST ---
Changes look good up to
<http://git.collabora.co.uk/?p=user/kakaroto/telepathy-gabble.git;a=commitdiff;h=39066174ee3cc>,
except that I'd like all the instances of gtalk_fc, GTALK_FC and (if any)
GTalkFc to be gtalk_file_collection, etc.

Still reviewing the subsequent patches...

> So for now we have :
> - Remove the MEDIA_TYPE for jingle-share
> - Remove special cases in jingle-content and add some new virtual methods for
> jingle-share.
> - use gabble_generate_id.
> - wrote decision algo on whether to use jingle or SI (right now, it uses jingle
> only if SI is not supported (gtalk)).
> - fix my TODO tags

and also:

* (me) finish reviewing your changes
* (me) review HTTP implementation in detail
* (me) second-pass review of the whole lot
* (you) any further changes coming from those


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.