[Bug 27311] Allow WockyPubsub subclasses to extend create/delete; extend data forms code to support blind form submission

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27311





--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-03-25 10:54:24 PST ---
> +WockyXmppStanza *wocky_pubsub_service_create_create_node_stanza (

Rename to w_p_s_new_c_n_s or w_p_s_make_c_n_s? Or keep the current name for
comedy value, either works :-)

> +WockyXmppStanza *
> +wocky_pubsub_node_make_delete_stanza (
> +    WockyPubsubNode *self,
> +    WockyXmppNode **pubsub_node,
> +    WockyXmppNode **delete_node)
...
> +  WockyXmppNode *p, *d; /* if we didn't have these, we'd have a great album */
...
> +        WOCKY_NODE_ASSIGN_TO, &p,
...
> +  if (pubsub_node != NULL)
> +    *pubsub_node = p;

Perhaps "WOCKY_NODE_ASSIGN_TO, NULL," should be defined to be a no-op, so that
users of stanza_build don't have to do this dance every time?

> -  /* This stanza is inspired from Example 2 of XEP-0004: Data Forms */
> +  /* This stanza is inspired from Example 2 of XEP-0004: Data Form */

-1, over-zealous search and replace. Example 6 has the same problem.

> +data_form_set_value (WockyDataForm *form,
> +    const gchar *field_name,
> +    GValue *value,

Please say explicitly that the value must be slice-allocated.

Other than that, this all looks good.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.