[Bug 27167] Gabble MailNotification.RequestInboxURL returns empty string

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27167





--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-03-26 06:53:55 PST ---
(In reply to comment #2)
> (In reply to comment #1)
> > I'd prefer it if this was what happened: I think it should be valid to call
> > Subscribe and immediately follow up with RequestInboxURL.
> 
> Both solution makes it valid, that was the bug I was trying to fix ;)

Sorry, I wasn't clear enough there. What I mean is:

* call Subscribe
* call RequestInboxURL
* time passes
* Subscribe succeeds
* RequestInboxURL succeeds

(to get an inbox URL without having to wait for two D-Bus round-trips).

> > (It's clearly wrong to call RequestMailURL before you have any mails, though
> > :-)
> 
> Well no, it's right since you want have access to the web interface at anytime,
> not only when count >= 0.

It's OK to call RequestInboxURL before you have mail, but RequestMailURL not so
much :-)

> The only thing I can't stand is having to add more non-public crap into
> connection.h. What I would propose is to create a precedent, where an extension
> would define a private pointer to it's private data using an opaque structure.
> This way, you don't have to change the connection every-time a new private
> member must be added.

Given that we're not writing a library, I think the current approach is fine;
there's considerably less pointer-chasing this way.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.