[Bug 27274] Make the telepathy logger extensions library public

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27274





--- Comment #13 from Travis Reitter <travis.reitter at collabora.co.uk>  2010-03-26 17:47:44 PST ---
(In reply to comment #12)
> Have you tested this in both modes, and checked what gets installed, and what
> goes into a "make dist" tarball? I infer that you haven't, because afaics,
> extensions.h will get installed even if the library isn't, and some of the
> generated stuff incorrectly goes in the tarball.

I was careful to check what got installed when I built with and without
--enable-public-extensions, though I mainly checked whether client libaries
would cleanly build against it if installed and cleanly detect it wasn't
installed (eg, based on the .pc file) as necessary. I guess I missed that some
headers were installed in the disabled state.

I completely missed on the "make dist" point, though. Thanks for pointing it
out.


I've applied your suggestions (and rebased against head) in my (slightly
misnamed) ext-library-merged branch. This seems to work well for all cases,
including building from the resulting "make dist" tarball.

The only issue is that, when building from the "make dist" tarball, without
external library support, ${includedir}/tpl-extensions/_gen gets installed,
though without any headers in it or its parent dir. For whatever reason, this
doesn't get installed if I build straight from the git tree.

Anything else that needs to happen before we can merge this? (As far as I can
see, any licensing issues with libtelepathy-logger shouldn't block the specific
changes in this bug, right?)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.