[Bug 27274] Make the telepathy logger extensions library public

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27274





--- Comment #14 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-03-29 08:46:52 PST ---
> +extensions/tpl-extensions.pc
> +extensions/_gen/
> +extensions/doc/
> +tests/test-*[^ch]
> +tests/twisted/telepathy-logger-debug
> +tests/twisted/tools/exec-with-log.sh
> +tests/twisted/tools/org.freedesktop.Telepathy.Client.Logger.service
> +tests/twisted/tools/tmp-session-bus.conf

Please anchor .gitignore paths at the repository root where possible, by
prefixing "/". Please keep .gitignore sorted approximately ASCIIbetically (i.e.
certainly tests/ below src/).

(/foo/bar matches only foo/bar in the root of the repository; foo/bar would
also match doc/foo/bar, for example.)

> +nodist_geninclude_HEADERS = \
>      _gen/signals-marshal.h \

You shouldn't need to install this: nothing that's installed should have to
include it. As such, it should move to nodist_blahblah_SOURCES.

> +    _gen/register-dbus-glib-marshallers-body.h \

The same reasoning applies to anything-body.h, which should be in SOURCES
(they're essentially a generated .c, but aren't self-contained - they're
designed to be #include'd into something that has first included the required
headers).

(After the whole branch is taken into account, this essentially means moving
some things from gen_headers into SOURCES.)

(In reply to comment #13)
> The only issue is that, when building from the "make dist" tarball, without
> external library support, ${includedir}/tpl-extensions/_gen gets installed,
> though without any headers in it or its parent dir. For whatever reason, this
> doesn't get installed if I build straight from the git tree.

If you can't avoid this, it's harmless. I'd prefer it if you could avoid it:
try moving these two lines inside the conditional, perhaps?

> tplincludedir=$(includedir)/tpl-extensions
> genincludedir=$(tplincludedir)/_gen

> Anything else that needs to happen before we can merge this? (As far as I can
> see, any licensing issues with libtelepathy-logger shouldn't block the specific
> changes in this bug, right?)

No, obtaining relicensing from GPL to LGPL is not a blocker for this bug.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.