[Bug 27374] GetContactAttributes() is specified to be needlessly fascist about interfaces

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27374


Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://git.collabora.co.uk/?
                   |                            |p=user/wjt/telepathy-
                   |                            |butterfly.git;a=commit;h=68f
                   |                            |3333cbefe3ce029d1d239b407782
                   |                            |8c71984b2




--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk>  2010-03-30 11:56:39 PST ---
Here's a Butterfly patch. People who use Butterfly should probably test that it
works. :)

Simon said on bug 27325:
> Non-review-blocker:
> 
> > +                logger.debug("Ignoring unsupported interface " + interface)
> 
> logger.debug("Ignoring unsupported interface %s", interface) is conventional
> (if called with more than one argument, logger methods interpolate their
> arguments into the first one as if via %).

Someone should tell this to the rest of butterfly, which always uses either +
or % rather than just passing extra args. I've updated my patch to use %.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.