[Bug 27899] Use more debug levels

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27899

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/ |
                   |?p=user/smcv/telepathy-glib |
                   |-smcv.git;a=shortlog;h=refs |
                   |/heads/error-macros         |
  Status Whiteboard|review+                     |
           Keywords|patch                       |

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-03 03:22:22 PDT ---
Thanks, merged for 0.11.5.

(In reply to comment #4)
> Yeah, looks alright. I'm guessing you can use sed correctly so didn't check
> 8b96c0066 very thoroughly.

I didn't just sed this - some of the calls already used G_STRFUNC, which is now
redundant. I re-checked the patch before merging, though, and I think the
compiler would catch most failure modes in those format strings anyway.

Now that _tp_log() is always compiled, I wonder whether we should change the
logic further, at least for cases where there's a debug sender, to:

* if --enable-debug:
  - DEBUG() always goes to the debug sender
  - if the debug sender's Enabled property is true, if (DEBUGGING) blocks
    are entered regardless of debug flags
  - if the appropriate debug flag is enabled, if (DEBUGGING) blocks are
    entered, and DEBUG() also goes to the default log handler
* else (--disable-debug):
  - DEBUG() aren't compiled
  - if (DEBUGGING) becomes if (0) and isn't entered
  - everything else behaves as normal

Otherwise, enabling the debug sender turns on Gabble debug in Empathy or
ceiling-cat, but does not turn on telepathy-glib debug :-(

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.