[Bug 27874] TpBaseClient Approver support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27874

--- Comment #1 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-05-04 02:32:40 PDT ---
I'm not sure about the best API for this.
The signature of my current callback for the AddDispatchOperation
implementation is:

typedef void (*TpBaseClientClassAddDispatchOperationImpl) (
    TpBaseClient *client,
    GList *channels,
    TpChannelDispatchOperation *dispatch_operation,
    TpAddDispatchOperationContext *context);

All the channels have TP_CHANNEL_FEATURE_CORE prepared and the CDO has
TP_CHANNEL_DISPATCH_OPERATION_FEATURE_CORE prepared.

The channels list is a bit redundant as we can get them using
tp_channel_dispatch_operation_borrow_channels().
On the other hand, TP_CHANNEL_DISPATCH_OPERATION_FEATURE_CORE doesn't prepare
the channels objects so the channels returned by
tp_channel_dispatch_operation_borrow_channels() are not guaranteed to be
prepared.

Should we remove the GList from this callback? In that case should we add a
TP_CHANNEL_DISPATCH_OPERATION_FEATURE_CHANNELS_CORE_PREPARED feature and ensure
that the CDO has this feature prepared?
If we do that, the list of channels passed to AddDispatchOperation() would be
ignored as CDO will fetch them from D-Bus.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.