[Bug 27956] TpBaseClient: should allow to observe invalidated signals

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27956

--- Comment #4 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-05-04 05:46:39 PDT ---
(In reply to comment #2)
> > +  if (tp_proxy_get_invalidated (source) != NULL)
> > +    {
> > +      /* Don't discard the channel as the invalidated channel is a valuable
> > +       * information for the Observer (to log a missed call for example). */
> > +      DEBUG ("Channel has been invalidated");
> > +    }
> > +  else if (!tp_proxy_prepare_finish (source, result, &error))
> 
> This doesn't look right... if preparing failed, it's almost certainly because
> the channel was invalidated. I think invalidation and failed-preparation should
> be treated the same - "every channel we're told to observe gets passed to user
> code" is a much easier guarantee to explain than "every channel we're told to
> observe gets passed to user code unless it somehow fails without actually being
> invalidated".

How can I check if the context is fully prepared then? There is no API to check
if we tried to prepare a feature and it failed.
Any better idea than using a counter for running calls?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.