[Bug 27948] TpBaseConnection: support AddClientInterest, RemoveClientInterest

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27948

--- Comment #2 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-05-04 07:33:29 PDT ---
  /* g_strdup (unique name) => gsize total count */
+  GHashTable *interested_clients;
+  /* GQuark iface => GHashTable {
+   *    unique name borrowed from interested_clients => gsize count } */
+  GHashTable *client_interests;

A comment explaining the relation between these 2 tables would be useful.

+static void tp_base_connection_interested_name_owner_changed_cb (
+    TpDBusDaemon *it, const gchar *unique_name, const gchar *new_owner,
+    gpointer user_data);

Should be one line per arg.

I'm not sure to properly understand code in _constructor iterating over types.

+#define SUPPORTED_INTERFACE "com.example.rannoch.ChineseHerbalMedicine"
I didn't get this reference ;)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.