[Bug 20035] Avatar cache reference implementation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=20035

--- Comment #12 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-06 10:33:52 PDT ---
If it's just the one patch, this looks pretty good. I haven't done a thorough
review of the refcounting and stuff.

Would a GFile be a better representation than a string? (I don't know...
comments welcome.)

> +    /* AvatarRetrieved signal is refcounted because we want to keep it
> +     * connected only when there are contacts waiting for their avatar data */

This seems like overkill to me. The expensive thing is getting the avatar data
from the server to the CM; once we've received it, we might as well do
something with it.

Note that we can sometimes retrieve avatars "spontaneously" - whenever an XMPP
contact's ContactInfo or nickname is downloaded, we get the avatar too - so
perhaps it would be best to connect to AvatarRetrieved in any client that cares
about avatar tokens?

I'm a little alarmed that there's no expiry on the avatar cache; avatars stay
forever. However, sensible expiry would probably have to be based on keeping a
record of last access times (or letting the filesystem do it for us, but that
doesn't work with noatime).

> +      "Avatar MimeType",

"Avatar MIME type"

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.