[Bug 27874] TpBaseClient Approver support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27874

--- Comment #14 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-05-07 06:24:45 PDT ---
(In reply to comment #13)
> (In reply to comment #12)
> > > > +  if (cls->priv->add_dispatch_operation_impl == NULL)
> > > > +    {
> > > > +      DEBUG ("class %s does not implement AddDispatchOperation",
> > > > +          G_OBJECT_TYPE_NAME (self));
> > > 
> > > CRITICAL()? This isn't meant to be reachable, AFAICS.
> > 
> > Wouldn't that make the client remotely crashable by calling a D-Bus method it
> > doesn't implement?
> 
> AFAICS, you already raised NotImplemented if the "is an approver" flag wasn't
> set, and trying to set that flag without having an AddDispatchOperation
> implementation would already have caused a critical?

You're right. Done for the Observer and Approver.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.