[Bug 26752] Setting a not supported presence state to a telepathy account does not deliver any failing feedback
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Fri May 7 16:24:21 CEST 2010
https://bugs.freedesktop.org/show_bug.cgi?id=26752
--- Comment #14 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-07 07:24:20 PDT ---
(In reply to comment #13)
> > telepathy-qt4
> > =============
> >
> > > + * \fn void Account::isChangingPresence(bool value);
> >
> > I think you mean changingPresence(bool).
> I Used isChangingPresence cause we use isSomething for other boolean accessors,
> as in isValid/isEnabled/... but I can change it if you prefer.
No, I was complaining about the *signal*'s documentation. Compare:
// getter
bool Tp::Account::isChangingPresence(void) const;
// signal
void Tp::Account::changingPresence(bool);
This is more subtle than it ought to be :-)
Would it perhaps be clearer if we had two signals, like this?
// getter
bool Tp::Account::isChangingPresence(void) const;
// signal (part 1)
void Tp::Account::presenceChangeStarted(void);
// signal (part 2)
void Tp::Account::presenceChangeFinished(void);
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the telepathy-bugs
mailing list