[Bug 28018] Bind Account.ChangingPresence into Qt

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri May 7 16:33:14 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=28018

--- Comment #2 from Andre Moreira Magalhaes <andrunko at gmail.com> 2010-05-07 07:33:14 PDT ---
In reply to https://bugs.freedesktop.org/show_bug.cgi?id=26752#c14

> No, I was complaining about the *signal*'s documentation. Compare:
> 
>     // getter
>     bool Tp::Account::isChangingPresence(void) const;
> 
>     // signal
>     void Tp::Account::changingPresence(bool);
> 
> This is more subtle than it ought to be :-)
True I missed that. will fix.

> Would it perhaps be clearer if we had two signals, like this?
> 
>     // getter
>     bool Tp::Account::isChangingPresence(void) const;
> 
>     // signal (part 1)
>     void Tp::Account::presenceChangeStarted(void);
> 
>     // signal (part 2)
>     void Tp::Account::presenceChangeFinished(void);
Hmm I am not sure about this, it surely would be more clear, but having one
signal I believe it's easier to implement. We can have on signal handler to
start/stop blinking the UI for example. Not sure here

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list