[Bug 20768] Support more ways to be invisible (XEP-0186, maybe XEP-0126, maybe whatever Google does)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=20768

--- Comment #16 from Will Thompson <will.thompson at collabora.co.uk> 2010-05-07 08:38:56 PDT ---
I've got a branch at
http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=shortlog;h=refs/heads/invisibility
where I merged current master and fixed up this branch to work with it, and
fixed a few of the simple points above. Working on the rest...

(In reply to comment #14)
> tests/twisted/presence/invisible_xep_0186.py:
> 
> +    assert ("hidden" in conn.Get(cs.CONN_IFACE_SIPLE_PRESENCE, "Statuses",
> +                                 dbus_interface=cs.PROPERTIES_IFACE).keys())
> 
> This could be assertContains("hidden",
> conn.Properties.Get(cs.CONN_IFACE_SIMPLE_PRESENCE, "Statuses")) I think.

Fixed in my branch.

> tests/twisted/presence/invisible_helper.py:
> 
> +    def _cb_invisible_success(self, iq):
> +        reply = elem_iq(self, 'result', id=iq["id"])
> +        self.send(reply)
> +
> +    def _cb_invisible_fail(self, iq):
> +        reply = elem_iq(self, 'error', id=iq["id"])
> +        self.send(reply)
> 
> These could use acknowledge_iq and send_error_reply.

Fixed in my branch.

> set_own_status_cb() looks like this:
> 
>   if (...)
>     {
>       ...
>       goto OUT;
>     }
>   if (...)
>     {
>       ...
>     }
>   else
>     {
>       ...
>     }
> 
>   OUT:
>     ...
> 
> I think the goto makes this harder to follow than just making the second 'if'
> an 'else if', which is the effect of this code anyway.

Fixed in my branch.

> +      GError *error;
> +      /* XEP-0018 */
> 
> should initialize error to NULL. `make check` should catch this: we have a
> script that greps for uninitialized GError *s.

Fixed.

> set_xep0126_invisible(): the stanza_build calls could use some indenting. (ISTR
> from my time trying it out that emacs is very keen not to let you do this. :/)

Fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.