[Bug 27622] Pluggable SASL authentication

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27622

--- Comment #20 from Eitan Isaacson <eitan.isaacson at collabora.co.uk> 2010-05-07 10:43:09 PDT ---
(In reply to comment #19)
> > > wocky-jabber-auth stream error parsing loop should probably do wocky_node_iter
> > > instead of a for loop of the children
> > 
> > this is existing code from wocky-sasl-auth.c, i cleaned up both: 0339ffd
> 
> Cool, if i'm not mistaken it's exactly the same code in both? Throw it in a
> utilty function maybe ? (maybe in wocky-xmpp-error.c ? to compliment the more
> modern wocky_xmpp_stream_error_from_node)

There already is a wocky_xmpp_stream_error_from_node function.
Looks like we saved 22 likes of code! dfbce16

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.