[Bug 27874] TpBaseClient Approver support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27874

--- Comment #16 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-10 02:54:40 PDT ---
> +        "dbus-connection", ((TpProxy *) bus_daemon)->dbus_connection,

This is redundant - just pass in the bus daemon and TpProxy will DTRT. Add a
check to the regression test that the dbus-connection is the same as the bus
daemon's dbus-connection, if you're worried.

Strictly speaking, _tp_channel_dispatch_operation_new_with_objects doesn't need
the bus_daemon argument - it could get it from the TpAccount - but that's
probably unnecessarily subtle.

Other than that, this looks good.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.