[Bug 27791] 3rd party code needs to be able to map SSO (libaccounts) IDs to account object paths

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon May 10 14:01:33 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=27791

--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2010-05-10 05:01:33 PDT ---
(In reply to comment #2)
> > I think you're doing this wrong: g_key_file_get_string + g_strsplit isn't
> > suitable for retrieving a string list (for a start, it behaves incorrectly in
> > the presence of escaped semicolons, if there ever are any). Why don't you use
> > g_key_file_get_string_list?
> 
> The plugin does't know there is even a key file - it uses the shim interface
> which only lets it set a string - SSO service names can't have ; in them,
> so that was used as a separator

It sounds to me like the shim interface is at fault here. :)

> > +        GError *error = g_error_new (TP_TYPE_ERROR,
> > +                                     TP_ERROR_DOES_NOT_EXIST,
> 
> It'd be good to document this possible error in the XML.

This doesn't seem to have happened.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list