[Bug 20035] Avatar cache reference implementation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=20035

--- Comment #18 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-05-10 07:47:31 PDT ---
(In reply to comment #16)
> >   dir = g_build_filename (g_get_user_cache_dir (),
> >       "telepathy", "avatars", cm_name, protocol, NULL);
> > Wouldn't it be better to use the account rather than the connection to build
> > this directory?
> 
> TpContact doesn't know about account, it only has a TpConnection.

Right.
Smcv: what would you suggest here?

> > Also, you changed the semantic as those function doesn't return any more in
> > such case.
> 
> I don't think it's bad to continue with the valid features requested, should be
> fine.

Not sure what's our policy there.

> > I think it would be better to add a function after the old code adding more
> > features if needed.
> 
> What do you mean?

keeping the current code checking feature and return_if_fail if needed and add
the extra features after.

> > No having tests makes me cry, especially as TpContact is pretty well tested so
> > far. I let smcv decide if that's a merge blocker or not.
> 
> I'll see if it's easy to write some.

Shouldn't be too hard we already have fake CM and stuffs. Just mimic what's
done in the current contact tests.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.