[Bug 24910] GSM IMSI accessor

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=24910

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|review+                     |http://git.collabora.co.uk/
                   |                            |?p=user/ptlo/tp-spec-senko/
                   |                            |.git;a=shortlog;h=refs/head
                   |                            |s/cellular
  Status Whiteboard|                            |review+
         AssignedTo|telepathy-bugs at lists.freede |senko.rasic at collabora.co.uk
                   |sktop.org                   |

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-14 03:57:34 PDT ---
review+ as a draft from me too.

Some non-blocker comments:

> +    <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
> +      <p>This interface is for various cellular things (GSM and/or CDMA) things that
> +        aren't really applicable to other protocols.</p>
> +    </tp:docstring>

remove the second instance of "things"

> +    <property name="MessageValidityPeriod" tp:name-for-bindings="Message_Validity_Period"
> +      type="u" access="readwrite">

This doesn't seem to have any change notification. Either add some, or
explicitly say that there isn't any at the moment and UIs should retrieve it
once for each time they want to display it (or something)?

(In practice I think this'd manifest as: when you click on "Cellular" in a
settings menu or something, a dialog opens, and that dialog retrieves the
property exactly once)

Also, in future I'd like a blank line between <p> elements to improve source
readability (and usability of the {} keys in vim :-)

> +        <p>The International Mobile Subscriber Identifier, if it exists. This
> +          would originate from a SIM card.  If the IMSI is unknown, this will
> +          contain an empty string ("").</p>

Do we want to distinguish between "no SIM" and "I have a SIM but I don't know
its IMSI"? If we do, we could represent "no SIM" as a reserved string that
isn't syntactically a valid IMSI, perhaps "-"; but we probably don't actually
care.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.