[Bug 20035] Avatar cache reference implementation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=20035

--- Comment #20 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-05-17 06:20:04 PDT ---
prepare_avatar_requirements_cb

Shouldn't you use g_assert_no_error rather than ignoring errors?

We stopped using MYASSERT in new tests. Jut use g_assert, g_assert_cmpuint,
etc.


create_contact_with_fake_avatar (ContactsConnection *service_conn,
                                 TpConnection *client_conn,
                                 const gchar *id)
args should be 4 spaces aligned


  MYASSERT_SAME_STRING (tp_contact_get_avatar_mimetype (contact),
avatar_mimetype);
this line is too long.

  MYASSERT (avatar_retrieved_called == TRUE, "");
juse use "g_assert (avatar_retrieved_called)"

  g_setenv ("XDG_CACHE_HOME", "/tmp", TRUE);
use g_get_tmp_dir()
Shouldn't we create a subdirectory in /tmp to be sure to not have name clashes
if files already exist?

+avatar_data_new (GArray *data, const gchar *mimetype, const gchar *token)

+void contacts_connection_change_avatar_data (ContactsConnection *self,

+my_request_avatars (TpSvcConnectionInterfaceAvatars *avatars,
+                    const GArray *contacts,
style is wrong

Did you valgrind the test?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.