[Bug 28111] tools trivia: make page titles fit in browser tabs, and remove obsolete devhelp index generation

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon May 17 16:54:05 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=28111

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Status Whiteboard|                            |review+ with minor changes
         AssignedTo|telepathy-bugs at lists.freede |will.thompson at collabora.co.
                   |sktop.org                   |uk

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-17 07:54:04 PDT ---
r+ for the second commit, feel free to cherry-pick it while we discuss the
first.

> +        # Bit of a hack, but... I want useful information about the current
> +        # page to fit in a tab in Chromium. I'm prepared to be disagreed with.
> +        self.really_short_name = (
> +            self.short_name.replace('Interface', 'I')
> +                           .replace('Channel.', 'Chan.')
> +                           .replace('Connection.', 'Conn.')
> +            )

I'd prefer to anchor the patterns with a dot before *and* after, like:

    self.short_name.replace('.Interface.', '.I.')

to avoid problems if someone defines a GraphicalUserInterface interface, or
something. With that change in all three substitutions, consider it reviewed.

I wouldn't object to replacing ".Type." with ".T." either.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list