[Bug 20035] Avatar cache reference implementation

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue May 18 12:40:02 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=20035

--- Comment #23 from Xavier Claessens <xclaesse at gmail.com> 2010-05-18 03:40:01 PDT ---
(In reply to comment #22)
> +/* Stolen from telepathy-haze */
> You should add copyright/licence info regarding this code.

Amended the last commit to include that.

> You can use "make -C tests/dbus check-valgrind TESTS=test-contacts" to run a
> single test with valgrind. Some tests have all the needed false-positive
> suppressions; don't know if that's the case for this one.
> 
> You should check with smcv for his advice regarding controversial bits (Comment
> #18 basically).

That's what I did, it is missing tones of suppression rules... but didn't see
anything leaking.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list