[Bug 23641] [regression] Re-implement keep-alive support

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri May 21 13:58:49 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=23641

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review-, style tweaks
         AssignedTo|telepathy-bugs at lists.freede |senko.rasic at collabora.co.uk
                   |sktop.org                   |

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2010-05-21 04:58:49 PDT ---
Much as I hate to nit-pick such a tiny branch...


+      if (priv->pinger != NULL)
+          g_object_set (priv->pinger, "ping-interval",
+              priv->keepalive_interval, NULL);

...the g_object_set is indented too far, and...

+  priv->pinger = wocky_ping_new (priv->porter,
+      priv->keepalive_interval);

...this doesn't really need to be wrapped!

I am happy that the branch can be this small :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list