[Bug 25183] HandleWith should have a User_Action_Time argument

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=25183

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|adds stable API, smcv r+,   |adds stable API, review+
                   |impl-needed                 |

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-25 06:33:24 PDT ---
Please merge this to the spec, and clone to MC for the implementation.

Quick review on the implementation:

-                      
tp_svc_channel_dispatch_operation_return_from_handle_with (
-                            approval->context);
+
+                        if (!approval->handle_with_time)
+                        
tp_svc_channel_dispatch_operation_return_from_handle_with (
+                              approval->context);
+                        else
+                        
tp_svc_channel_dispatch_operation_return_from_handle_with_time (
+                              approval->context);

You don't actually need this complexity (or the boolean), because HandleWith
and HandleWithTime both return the same thing: you can just put a comment
"HandleWith and HandleWithTime both return void, so it's OK to not distinguish"
above the call to tp_svc_channel_dispatch_operation_return_from_handle_with.

Similarly, with a similar comment it would be OK (and, IMO, clearer) to
implement dispatch_operation_handle_with as a simple call to
dispatch_operation_handle_with_time.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.