[Bug 28270] Remove libmcclient from mc-tool

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu May 27 12:42:32 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=28270

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-27 03:42:32 PDT ---
I didn't review "Change names of variables that shadow global functions", I
assume that's the same as the one I just reviewed elsewhere.

> -    if (startswith (string, account_prefix))
> +    if (startswith (string, TP_ACCOUNT_OBJECT_PATH_BASE))

This could probably be g_str_has_prefix(), too?

> This reenables NormalizedName and AutomaticPresence by requesting those
> properties directly from the Account Manager, since they are not exposed
> via TpAccount.

File bugs? NormalizedName is not amazingly useful IMO, but AutomaticPresence
could be.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list