[Bug 27270] API review: TplLogManager

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27270

--- Comment #4 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-05-27 05:00:12 PDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > API used by empathy:
> > 
> > tpl_log_manager_dup_singleton ()
> > tpl_log_manager_exists ()
> > tpl_log_manager_get_chats_async ()
> > tpl_log_manager_get_chats_async_finish ()
> > tpl_log_manager_get_date_readable ()
> > tpl_log_manager_get_dates_async ()
> > tpl_log_manager_get_dates_async_finish ()
> > tpl_log_manager_get_filtered_messages_async ()
> > tpl_log_manager_get_filtered_messages_async_finish ()
> > tpl_log_manager_get_messages_for_date_async ()
> > tpl_log_manager_get_messages_for_date_async_finish ()
> > tpl_log_manager_search_free ()
> > tpl_log_manager_search_new_async ()
> > tpl_log_manager_search_new_async_finish ()
> > 
> > I moved all the other API (including the sync ones) as internal:
> > http://git.collabora.co.uk/?p=user/cassidy/telepathy-logger;a=shortlog;h=refs/heads/log-store-api-27270
> 
> I approve of that branch. Please leave this bug open, we still need to review
> the API.

merged.

> More suggested changes:
> 
> >  /**
> > - * tpl_log_manager_get_dates:
> > + * _tpl_log_manager_get_dates:
> 
> Replacing /** with /* might reduce confusion in gtk-doc?

What do you mean?
/** is the right way to start the documentation of a function.

> > -/* Start of tpl_log_manager_search_in_identifier_chats_new async implementation */
> > +/* Start of tpl_log_manager_search_in_identifier_chats_new async
> > + * implementation */
> 
> I don't like these comments; they're essentially content-free (we can see what
> function goes where by reading the function names!). Just delete them.

removed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.