[Bug 28289] McpAccountStorage::toggled is unimplemented

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri May 28 12:03:58 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=28289

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Status Whiteboard|                            |review+ with minor changes
         AssignedTo|telepathy-bugs at lists.freede |danielle.madeley at collabora.
                   |sktop.org                   |co.uk

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-28 03:03:58 PDT ---
> +gboolean
> +mcd_account_set_enabled (McdAccount *account,

This should be _mcd_account_set_enabled in mcd-account-priv.h (-priv is the MC
equivalent of -internal in telepathy-glib). Adding more API to
libmissioncontrol-server is deprecated, while we try to get rid of it.

> +  mcd_account_set_enabled (account, on, FALSE, &error);
> +  if (error != NULL)

Trivia: blank line before "if", please.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list