[Bug 27645] Implement SASL authentication channels.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27645

--- Comment #13 from Will Thompson <will.thompson at collabora.co.uk> 2010-05-28 03:26:44 PDT ---
(In reply to comment #11)
> (In reply to comment #9)
> > gabble_server_sasl_channel_start_mechanism() assumes priv->result != NULL
> > without an assertion; _respond() makes the same assumption, and does assert. I
> > think this makes Gabble remotely crashable, if someone calls these D-Bus
> > methods at the wrong time? Better to raise an error (NotAvailable or similar?)
> > or abort the whole thing if a client messes up, rather than crashing. (Or if it
> > doesn't crash, I can't see why not, so a test and more obvious robustness would
> > be good. :) )
> 
> 87667b8

Won't this:

+  if (!g_simple_async_result_is_valid (G_ASYNC_RESULT (priv->result),
+          G_OBJECT (self), wocky_auth_registry_start_auth_finish))

still crash if priv->result is NULL?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.