[Bug 27881] Should use TpSimpleObserver

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27881

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|telepathy-bugs at lists.freede |guillaume.desmottes at collabo
                   |sktop.org                   |ra.co.uk

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-31 05:54:36 PDT ---
Looks good, but I'd prefer a couple of additional changes:

> error:
> ...
> +  DEBUG ("Returning from observe channels on error condition. "
> +      "Unable to log the channel");
> +
> +  tp_observe_channels_context_accept (context);

What errors can occur? It seems more correct to use
tp_observe_channels_context_fail() (in practice MC will log the error, then
carry on regardless).

> +  if (tp_base_client_register (TP_BASE_CLIENT (observer), &error) == FALSE)

Don't compare booleans to TRUE and FALSE:

if (!tp_b_c_r (..., &error))
  {
    ...
  }

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.