[Bug 27247] Shouldn't hardcode list of wocky headers to install

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27247

--- Comment #5 from Will Thompson <will.thompson at collabora.co.uk> 2010-05-31 08:47:10 PDT ---
(In reply to comment #4)
> I managed to get this working again:
> 
> http://git.collabora.co.uk/?p=user/maiku/wocky.git;a=shortlog;h=refs/heads/install-headers
> http://git.collabora.co.uk/?p=user/maiku/telepathy-gabble.git;a=shortlog;h=refs/heads/update-wocky-headers-alternate

Look good! (I feel bad, though; maybe you should claim --author-dom of these
patches. ☺)

Oh, one thing, the Gabble branch should delete my beautiful
gabble/generate-wockyinclude_HEADERS script.

> I noticed though one issue is that if you configure wocky with
> --with-installed-headers, but without setting it to a value, it installs the
> headers in a yes/ directory. That happens because if no value is set,
> AC_ARG_WITH sets the variable to "yes". I'm not sure how best to handle that
> though or how it should ideally act. Suggestions? or is it fine like it is?

I don't think it's that big a deal. I guess the options are, explicitly check
for "yes" (and warn/fail), or use some other macro other than AC_ARG_WITH that
doesn't have this behaviour? But given that this flag is pretty much just for
Gabble's benefit...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.