[Bug 28705] More documentation about credentials and components in stream

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28705

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olivier.crete at ocrete.ca
             Blocks|                            |29590

--- Comment #2 from Olivier Crête <olivier.crete at ocrete.ca> 2010-10-31 18:47:16 PDT ---
(In reply to comment #1)
> More from 24936
> 
> > * Does it ever make sense to remove a local candidate? If it does, we'll need a
> > LocalCandidatesRemoved signal

No, never.

> > * What is LocalCredentials and what is its rationale?

It is the crds that you put in the SDP you send.

> > * How many times can LocalCredentialsSet happen? 0-1? 0-infinity?

If you call it again, it mans you're doing a ICE restart.. Which mean syou
forget about remote canifdates and expect new ones.

> > * Am I right in thinking that Stream.I.Media deals with local candidates (ways
> > in which the local user tells remote users that we can perhaps be contacted)
> > while remote candidates (ways in which remote users tell us they can perhaps be
> > contacted) are all dealt with by Endpoint? The (missing) introductory docstring
> > should say this sort of thing.

Yes are right, it should be clearer though. You can have multiple endpoints
because with SIP you can get multiple replies from the same invite request.

> > * If I infer correctly that LocalCredentials, LocalCandidates come from the
> > streaming implementation and nowhere else, do they actually need to be readable
> > at all, or can they be "write-only" (i.e. not exist as properties at all, only
> > as setter methods)?

Being able to read them could be useful for debugging I guess ?


> > * The descriptions in Candidate_Info aren't sufficient for me to understand
> > what they're for.

About Candidate_Info:
- Type is a uint, but we have no idea what the values mean
- BaseIP should be a string, not uint
- BasePort is missing
- What is the scale of the priority? (it should be a number between 0 and
65535)
- Add multicast type and a TTL field for it
- Protocol is also a uint, but we have no idea what it means
- RawUDPFallback should go away, the lowest priority candidate is normally the
fallback (its the relay).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.