[Bug 31216] Implement stable version of MailNotification

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31216

Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review- (need small fix,
                   |                            |nothing major)

--- Comment #1 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2010-11-02 11:45:06 PDT ---
+  else
+    {
+      DEBUG ("We no longer care about unread mail");
+    }

You already trace when interest goes to FALSE, why tracing again ?

+  if (!(conn->features & GABBLE_CONNECTION_FEATURES_GOOGLE_MAIL_NOTIFY))
+    {
+      DEBUG ("Not a Google server - no MailNotification here");
+      return;
+    }

This trace does not give information, please remove.

-  return TRUE;
+#define MY_INTERFACE GABBLE_IFACE_CONNECTION_INTERFACE_MAIL_NOTIFICATION
+  g_signal_connect (conn, "clients-interested::" MY_INTERFACE,

Please undef MY_INTERFACE at the end, or don't use it. I'm not a big fan of
using defines for such trivial constructions. Maybe you should use "const gchar
*self_interface = GABBLE_IFACE_CONNECTION_INTERFACE_MAIL_NOTIFICATION" or
similar instead ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.