[Bug 31216] Implement stable version of MailNotification

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31216

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review- (need small fix,    |
                   |nothing major)              |

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-11-03 05:25:41 PDT ---
(In reply to comment #1)
> You already trace when interest goes to FALSE, why tracing again ?

No good reason, really; I was using the vague rule of thumb that if one code
path logs, all of them should log. fb61a6c6bc97c79

> This trace does not give information, please remove.

Same commit as above.

> Please undef MY_INTERFACE at the end, or don't use it. I'm not a big fan of
> using defines for such trivial constructions. Maybe you should use "const gchar
> *self_interface = GABBLE_IFACE_CONNECTION_INTERFACE_MAIL_NOTIFICATION" or
> similar instead ?

I'm relying on cpp string concatenation and I don't really want to
g_strdup_printf the constant signal names, so, no. d8794e70cee1de4 drops the
use of MY_INTERFACE in favour of concatenating the full-length name, at the
cost that the lines are a bit over-long.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.