[Bug 31412] crashes during disconnection if a PEP alias request is in-flight

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31412

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review-, minor changes to
                   |                            |the test.

--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2010-11-05 10:41:45 PDT ---
Does not making vCard requests until we're Connected break people asking for
the alias or whatever while we're Connecting?

+      /* FIXME: what if vcard_manager is NULL? */
       if (request->vcard_requests[i] != NULL)
         gabble_vcard_manager_cancel_request (request->conn->vcard_manager,
             request->vcard_requests[i]);

What if, indeed. :/ I've never seen this crashing... ;-)

+    # We disconnect too soon to get a reply
+    call_async(q, conn, 'Disconnect')
+    q.expect_many(
+        EventPattern('dbus-signal', signal='StatusChanged',
+            args=[cs.CONN_STATUS_DISCONNECTED, cs.CSR_REQUESTED]),
+        EventPattern('stream-closed'),
+        )
+    stream.sendFooter()
+    q.expect('dbus-return', method='Disconnect')

I think there's a helper method for this.

+    # check that Gabble hasn't crashed
+    cm = bus.get_object(cs.CM + '.gabble',
+            '/' + cs.CM.replace('.', '/') + '/gabble')
+    call_async(q, dbus.Interface(cm, cs.CM), 'ListProtocols')
+    q.expect('dbus-return', method='ListProtocols')

Should we make sync_dbus() use this and just call that? (Would its current
implementation do?)

The Gabble changes in this branch do look kosher... and we really need to clean
this up one of these days.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.