[Bug 31474] [Patch] Make CA cert paths configurable more friendly

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31474

--- Comment #5 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2010-11-09 14:36:01 PST ---
Review of attachment 40123:
 --> (https://bugs.freedesktop.org/review?bug=31474&attachment=40123)

I think I'd prefer keeping the option and define name we had originally used to
avoid breaking packagers work.

::: configure.ac
@@ -99,4 +99,6 @@
-AC_ARG_WITH(ca-certificates,
-    AC_HELP_STRING([--with-ca-certificates],[path to CA certificates
@<:@default=/etc/ssl/certs/ca-certificates.crt@:>@]),
-    ca_certificates_path="$withval",
ca_certificates_path="/etc/ssl/certs/ca-certificates.crt")
-AC_DEFINE_UNQUOTED(CA_CERTIFICATES_PATH, ["${ca_certificates_path}"], [Path to
CA certificates])
+# -----------------------------------------------------------
+# Make CA certificates path configurable
+# Stolen from GIO's TLS
... 3 more ...

I don't like renaming a compilation option, some packagers already uses
--with-ca-certificates.

@@ -99,4 +99,30 @@
-AC_ARG_WITH(ca-certificates,
-    AC_HELP_STRING([--with-ca-certificates],[path to CA certificates
@<:@default=/etc/ssl/certs/ca-certificates.crt@:>@]),
-    ca_certificates_path="$withval",
ca_certificates_path="/etc/ssl/certs/ca-certificates.crt")
-AC_DEFINE_UNQUOTED(CA_CERTIFICATES_PATH, ["${ca_certificates_path}"], [Path to
CA certificates])
+# -----------------------------------------------------------
+# Stolen from GIO's TLS
+else
... 27 more ...

I don't like using GLib like namespace in Gabble, also why do we change it from
original name, CA_CERTIFICATES_PATH

::: src/connection.c
@@ +1967,2 @@
   /* system certs */
+  wocky_tls_handler_add_ca (tls_handler, GTLS_SYSTEM_CA_FILE);

This is not required if you keep original name.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.