[Bug 31581] New: tp_group_mixin_remove_members_with_reason breaks API guarantees

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31581

           Summary: tp_group_mixin_remove_members_with_reason breaks API
                    guarantees
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-glib
        AssignedTo: simon.mcvittie at collabora.co.uk
        ReportedBy: jonny.lamb at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


I told my grandmother that she was fine to trust the highly documented
telepathy-glib library's API guarantees and that Simon McVittie knew what const
meant. I don't like lying to my grandmother, but lying to my grandmother is
what I have done.

tp_group_mixin_remove_members_with_reason takes a const GArray *contacts but
then modifies the contents of this const GArray*. Correct me if I'm wrong, but
const is for more than looking pretty in function arguments.

Perhaps you meant const GArray * const * const * GArray * const?

(btw, the offending commit is:

commit a36f21cbec16a1c9a92075d6c26827861e8ab53f
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Fri May 21 13:16:33 2010 +0100

    TpGroupMixin: when removing members, don't raise an error if it's a no-op

    This is awkward if two clients both try to remove the same member at the
    same time, for instance.
)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.