[Bug 29457] TpAccountChannelRequest: request-and-observe helper

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29457

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-11-17 08:42:37 PST ---
I haven't reviewed this in detail since merge is blocked, but it looks OK in
principle, except for this bit:

(In reply to comment #0)
> provide a new requesting method that will fail if your MC is too old for it
> (probably by fixing Bug #28866 at the same time), and make this telepathy-glib
> API (which would maybe be called
> tp_account_channel_request_ensure_and_observe_async()?) use it.

I'd prefer the "and observe" case to call EnsureChannelWithHints, which has the
guarantee that if it works, then SucceededWithChannel will be emitted.

That means that if MC can't provide the semantics demanded by the API user, we
get an error "cleanly", without the side-effect of creating an unobserved
channel.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.