[Bug 31686] Add avatar support to TpBaseProtocol

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31686

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+ with minor tweaks
                   |                            |when spec supports it

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-11-19 03:32:19 PST ---
> Added avatar protocol test.

This is good to have, but I'm not entirely happy about including P.I.Avatars in
an otherwise minimal example of Messages (whose connections do not, in fact,
implement Avatars). Perhaps the Protocol test could subclass the object from
the Messages CM, and use the subclass?

Alternatively, open a bug for doing that and move on; it'd be a pretty silly
reason to block undrafting :-)

The ideal solution would be to have a separate Avatars example one day, and use
that for this test (certainly not a merge blocker).

> + * @rec_height: (out): used to return the rec height in pixels

What I meant was:

     * @rec_height: (out): used to return the recommended height in pixels

Other than those two things, I think this is good for merge as soon as we've
integrated a spec in which it's undrafted.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.