[Bug 31757] implement Proto.I.Avatars in Haze

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Nov 19 12:51:33 CET 2010


https://bugs.freedesktop.org/show_bug.cgi?id=31757

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-11-19 03:51:31 PST ---
(If you're not going to be working on this beyond proof-of-concept, let me know
and I can pick it up.)

> +haze_protocol_get_avatar_details (TpBaseProtocol *base,

This duplicates the logic from _get_acceptable_mime_types in
connection-avatars.c, complete with the noted bug about image/ico. I'd prefer
it if you added a function like this:

GStrv haze_prpl_info_get_mime_types (PurplePluginProtocolInfo *prpl_info)
{
  ...
}

(I'd personally put it in protocol.[ch] but that's a matter of taste) and then
had both _get_acceptable_mime_types and haze_protocol_get_avatar_details call
it.

Bonus penguin points if you add a special case to fix the documented bug too:
Windows-style .ico files are officially of MIME type
"image/vnd.microsoft.icon".

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list