[Bug 31686] Add avatar support to TpBaseProtocol

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31686

--- Comment #6 from Eitan Isaacson <eitan.isaacson at collabora.co.uk> 2010-11-19 11:58:09 PST ---
(In reply to comment #5)
> > Added avatar protocol test.
> 
> This is good to have, but I'm not entirely happy about including P.I.Avatars in
> an otherwise minimal example of Messages (whose connections do not, in fact,
> implement Avatars). Perhaps the Protocol test could subclass the object from
> the Messages CM, and use the subclass?
> 

The generic protocol properties are tested using this CM in the
protocol-objects.c test, so adding the avatar interface to it was natural. If
anything, the entire TpBaseProtocol test should be factored out.

> Alternatively, open a bug for doing that and move on; it'd be a pretty silly
> reason to block undrafting :-)

I think I'll do that.

> 
> The ideal solution would be to have a separate Avatars example one day, and use
> that for this test (certainly not a merge blocker).

Or a separate Protocol example..

> 
> > + * @rec_height: (out): used to return the rec height in pixels
> 
> What I meant was:
> 
>      * @rec_height: (out): used to return the recommended height in pixels
> 
> Other than those two things, I think this is good for merge as soon as we've
> integrated a spec in which it's undrafted.

We need to wait for a spec release for that? In the meantime, I rebased the
branch and made it ready for a clean merge.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.