[Bug 31815] New: Keepalive ping timeouts don't cause the connection to die

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31815

           Summary: Keepalive ping timeouts don't cause the connection to
                    die
           Product: Wocky
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: General
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: will.thompson at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


If the server never responds to our keepalive pings, we don't do anything.
Instead, we should tear the connection down.

I think this means that wocky_porter_force_close_async() needs a reason
parameter saying why it's happened, to allow Gabble to explain what happened to
the user when the connection vanishes from underneath it.

We could also use g_socket_set_timeout() on the underlying GSocketConnection,
but this would depend on WockyXmppConnection knowing that its GIOStream is
actually a GSocketConnection. That seems okay to me. In fact, this is what
Loudmouth did: it blindly sent keepalive pings, and depended on the socket
dying to kill the connection. It seemed to work. But I don't know how this
interacts with proxies. I guess maybe we'd still need to do the
application-level timeouts in that case.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.