[Bug 23155] Connection: make handles survive until disconnection

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Nov 24 17:56:38 CET 2010


https://bugs.freedesktop.org/show_bug.cgi?id=23155

--- Comment #10 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-11-24 08:56:37 PST ---
(In reply to comment #9)
> We currently tie the contact attribute lifetime to the contact's handle's
> lifetime.

Not in any CM I'm familiar with... TpDynamicHandleRepo has qdata on handles,
but I don't think using it is necessarily wise.

In practice, I think CMs should only cache contact attributes for those
contacts where we can expect to get change notification: that's some
combination of the contacts on the contact list (if any) and the the contacts
we're in a channel with (if any).

For any other contacts, Get()-style methods returning information would be
pretty misleading anyway - we have no idea how stale it is. Request()-style
methods are still useful, but it's OK for those to re-query the server.

I think Salut is on the right track here: it has SalutContact objects which
encapsulate a contact and are refcounted. The telepathy-glib service-side could
optionally grow a TpSvcContact or TpBaseContact like Will suggested, but I'm
not sure whether that ought to be a base class or a GInterface - in CMs backed
by a good enough library, we'd probably want the Telepathy contact object to be
a subclass of WockyContact or whatever?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list