[Bug 31936] New: Papyon sends bad requests, which result in a memory leak in telepathy-butterfly

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31936

           Summary: Papyon sends bad requests, which result in a memory
                    leak in telepathy-butterfly
           Product: Telepathy
           Version: 0.4
          Platform: x86-64 (AMD64)
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: papyon
        AssignedTo: louis-francis.ratte-boulianne at collabora.co.uk
        ReportedBy: yoav.weiss.fr at gmail.com
         QAContact: telepathy-bugs at lists.freedesktop.org


Created an attachment (id=40585)
 View: https://bugs.freedesktop.org/attachment.cgi?id=40585
 Review: https://bugs.freedesktop.org/review?bug=31936&attachment=40585

Patch to avoid sending port number in URL when port is 80

Papyon 0.4.6 sends out requests to MSN's server that cause the server to return
a 400 HTTP response ("Bad Request").
When such responses are received, telepathy-butterfly (through it's use of
papyon) suffers from a huge memory leak. (about 200MB per hour on average)

Detailes:
In http://support.microsoft.com/kb/826437 you can see that the .Net framework
1.1 does not accept requests that contains ":" in the host name AND "&" in the
URL because of a bug.
Papyon sends requests to port 80 to a URL of the form:
http://65.54.48.32:80/gateway/gateway.dll?Action=poll&SessionID=962514443.0
The MSN server then responds to these responses with a '400 Bad Request'
response.
These responses also result in a huge memory leak.

Workaround:
Since it is not necessary to send the port number with the URL when the port
number is 80, I created a patch that avoids sending it in this case. This helps
to avoid the 400 responses as well as the memory leak.
This attached patch relates to the papyon/gnet/protocol directory

Further details:
OS - Ubuntu 10.04 64 bit with all latest updates.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.