[Bug 29218] TpStreamTube - high level stream tube API

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Oct 1 16:25:23 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=29218

--- Comment #30 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-10-01 07:25:22 PDT ---
The stuff in gnio-util.c depends on GUnixConnection, which makes it troublesome
to put in our API (GUnixConnection only conditionally exists).

The functions should be underscore-prefixed and in gnio-util-internal.h, or a
new unix-internal.h; they should only be defined if HAVE_GIO_UNIX.

If they're needed by something outside telepathy-glib, we'll have to introduce
a wrapper function which always exists, like this:

gboolean
tp_unix_connection_send_credentials_with_byte (GSocketConnection *sock,
    guchar byte,
    GCancellable *cancellable,
    GError **error)
{
#ifdef HAVE_GIO_UNIX
    return _tp_unix_connection_send_credentials_with_byte (
        G_UNIX_CONNECTION (sock), byte, cancellable, error);
#else
    g_set_error (G_IO_ERROR, G_IO_ERROR_NOT_SUPPORTED,
        "Unix sockets not supported");
    return FALSE;
#endif
}

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list