[Bug 30088] Implement Protocol.Interface.Presence, so it can be undrafted.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30088

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-10-05 07:56:16 PDT ---
The telepathy-glib branch shouldn't be merged as-is, because it edits spec/,
but this approach is OK as a trial implementation.

> +              /* assuming the string arg of a status is a message */

It'd be better to look for an argument called "message", like the mixin does.

I'm not sure whether non-core interfaces should be part of the
TpBaseProtocolClass. One alternative would be to have a TpPresenceProtocol
GInterface, a bit like TpBaseContactList? That might be overkill if we only
ever need this one Presence method, though.

I think the Gabble implementation should include any plugin-defined statuses,
because the Protocol statuses are defined to be a superset of all Connections'
statuses. This might require a hook by which plugins can indicate which
statuses they support.

> +  return g_strsplit (TP_IFACE_PROTOCOL_INTERFACE_PRESENCE, ";", -1);

This is a neat hack, but I think explicit is better than implicit: I'd prefer

    const gchar * const interfaces[] = {
        TP_IFACE_PROTOCOL_INTERFACE_PRESENCE,
        NULL };

    return g_strdupv ((GStrv) interfaces);

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.