[Bug 28199] port Gabble to TpBaseContactList

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28199

--- Comment #15 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-10-05 08:24:38 PDT ---
(In reply to comment #12)
> I could change it to REMOVED, but I think it might be clearer to stick to the
> XMPP phrasing.
...
> _subscription_to_string() and process_roster() assert this,
> _parse_item_subscription() can only return these, and I've just checked that no
> other states are assigned.
...
> I'm reasonably sure this is right: "no subscription and present on the contact
> list" and "no subscription and absent from the contact list" were previously
> conflated as NONE, so we now want to treat REMOVE much like NONE.

Are you sufficiently convinced by these to consider this branch to be ready for
merge?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.