[Bug 30631] Need a flag to indicate that a ContactInfo field is overwritten by nickname

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Oct 5 19:19:28 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=30631

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-10-05 10:19:28 PDT ---
Review of attachment 39183:
 --> (https://bugs.freedesktop.org/review?bug=30631&attachment=39183)

::: spec/Connection_Interface_Contact_Info.xml
@@ +473,3 @@
+
+      <tp:flag suffix="Overwritten_By_Nickname" value="2">
+        <tp:docstring>

Please set the XHTML xmlns on the <tp:docstring> and put the text in
paragraphs, like so, to get better spacing in the HTML output:

<p>Indicates ... this field</p>

<tp:rationale>
  <p>If a client ... first.</p>
</tp:rationale>

You can abbreviate org.freedesktop.Telepathy to ofdT in namespace attributes.

The actual text of this change looks fine, but I'd prefer it if you also said
something like:

    <p>If used, this flag typically appears on either the "nickname" or
      "fn" field.</p>

It also seems a good idea to recommend calling SetContactInfo *before* either
calling SetAliases or setting the Nickname, if both were changed, so that it's
harmless if the UI leaves the stale nickname in its "things to set" data
structure. Hopefully we can rely on connection managers to handle overlapping
edits correctly (Gabble does).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list