[Bug 30478] Add TP_ACCOUNT_FEATURE_STORAGE to TpAccount

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30478

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-10-06 08:27:56 PDT ---
(In reply to comment #5)
> Both of these seem reasonable to me (I wondered about them at the time). When
> do you plan to merge that branch?

When someone reviews it, hint hint? :-)

(But seriously: I should probably also finish the inverse of
dbus_g_value_build_g_variant before we start using TpVariantMap in APIs.)

>    if (error != NULL)
> -    {
> -      DEBUG ("Error getting Storage properties: %s", error->message);
> -      _tp_proxy_set_feature_prepared (proxy, TP_ACCOUNT_FEATURE_STORAGE,
> -          FALSE);
> -      return;
> -    }
> +    DEBUG ("Error getting Storage properties: %s", error->message);

Removing the early return looks wrong: properties will be NULL and all the
accesses to it will (either g_critical() or) crash. Did you test this case?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.